Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation notes #2875

Merged
merged 1 commit into from Mar 10, 2019

Conversation

Projects
None yet
2 participants
@nicolas-grekas
Copy link
Contributor

nicolas-grekas commented Mar 10, 2019

ExpressionParser still uses since version [...] because the message is not only about Twig: any package providing extensions can trigger it.

@fabpot

This comment has been minimized.

Copy link
Contributor

fabpot commented Mar 10, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 0f8d66b into twigphp:2.x Mar 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Mar 10, 2019

minor #2875 Fix deprecation notes (nicolas-grekas)
This PR was merged into the 2.x branch.

Discussion
----------

Fix deprecation notes

`ExpressionParser` still uses `since version [...]` because the message is not only about Twig: any package providing extensions can trigger it.

Commits
-------

0f8d66b Fix deprecation notes

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:deprec-twig branch Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.