Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter filter - support Traversable #3016

Closed
wants to merge 1 commit into from

Conversation

2 participants
@keksa
Copy link

commented May 17, 2019

solves #3015

@fabpot

This comment has been minimized.

Copy link
Contributor

commented May 18, 2019

Thank you for the pull request. As the bug also exists on 1.x, I've submitted a pull request for that version (#3017), which is a bit different as we need to support PHP 5.5 on 1.x. I've also written a test that only relies on internal PHP classes (\SimpleXMLElement is traversable but does not implement \Iterator).

@fabpot fabpot closed this May 18, 2019

fabpot added a commit that referenced this pull request May 18, 2019

bug #3017 Fix the "filter" filter when the argument is \Traversable b…
…ut does not implement \Iterator (fabpot)

This PR was merged into the 1.x branch.

Discussion
----------

Fix the "filter" filter when the argument is \Traversable but does not implement \Iterator

close #3015, closes #3016

Commits
-------

c2f685e fixed the "filter" filter when the argument is \Traversable but does not implement \Iterator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.