Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape __DIR__ in the test suite #3062

Merged
merged 1 commit into from Jun 11, 2019

Conversation

Projects
None yet
3 participants
@lyrixx
Copy link
Contributor

commented Jun 11, 2019

No description provided.

@@ -210,14 +210,14 @@ public function getErroredTemplates()
public function testTwigLeakOutputInDebugMode()
{
$output = exec(sprintf('%s %s debug', \PHP_BINARY, __DIR__.'/Fixtures/errors/leak-output.php'));
$output = exec(sprintf('%s %s debug', \PHP_BINARY, escapeshellarg(__DIR__.'/Fixtures/errors/leak-output.php')));

This comment has been minimized.

Copy link
@stof

stof Jun 11, 2019

Contributor

the same should be done for \PHP_BINARY, no ?

@fabpot

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

Thank you @lyrixx.

@fabpot fabpot merged commit fa0213a into twigphp:1.x Jun 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Jun 11, 2019

minor #3062 Escape __DIR__ in the test suite (lyrixx)
This PR was merged into the 1.x branch.

Discussion
----------

Escape __DIR__ in the test suite

Commits
-------

fa0213a Escape __DIR__ in the test suite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.