Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update include.rst #3086

Merged
merged 1 commit into from Jul 11, 2019

Conversation

3 participants
@Chrysweel
Copy link
Contributor

commented Jul 10, 2019

Fix in function include to set a filter

Update include.rst
Fix in function include to set a filter
@lyrixx

lyrixx approved these changes Jul 10, 2019

Copy link
Contributor

left a comment

👍 Good catch. But this goes on 1.x

@Chrysweel

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

And I think that if it is recommended to use the function include instead of the tag, I could change all the examples to use the function. But I have not done it because maybe you do not want to change.

@Chrysweel

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

Yes @lyrixx but this documentation is about 2.x the documentation about 1.x is in https://twig.symfony.com/doc/1.x/tags/include.html and has not this error in include.rst

@fabpot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Good catch, thanks @Chrysweel.

@fabpot fabpot merged commit 21fde2f into twigphp:2.x Jul 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Jul 11, 2019

minor #3086 Update include.rst (Chrysweel)
This PR was merged into the 2.x branch.

Discussion
----------

Update include.rst

Fix in function include to set a filter

Commits
-------

21fde2f Update include.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.