Add function twig *_name for intl

[seb-jean]

Hi,

I add language_names, script_names, country_names, locale_names, currency_names, timezone_names.

It allows us to have a list but on the Twig side and to use them in filters for example.

[seb-jean]

issue #3741

[fabpot]

Can you add the related docs?

[seb-jean]

Can you add the related docs?

I just added them.

[SpacePossum]

maybe some utest (coverage) could be added for the new code?

[seb-jean]

maybe some utest (coverage) could be added for the new code?

I don't know how to do it.

[GromNaN]

maybe some utest (coverage) could be added for the new code?

I don't know how to do it.

You can add test files in extra/intl-extra/Tests/Fixtures and run the test command:

cd extra/intl-extra
composer install
vendor/bin/simple-phpunit

[seb-jean]

maybe some utest (coverage) could be added for the new code?

I don't know how to do it.

You can add test files in extra/intl-extra/Tests/Fixtures and run the test command:

cd extra/intl-extra
composer install
vendor/bin/simple-phpunit

I just added them.

[GromNaN]

Good, the tests are exhaustive.
There is some words to replace in the doc.
The fabbot issue is wrong.

[fabpot]

It looks like tests are broken.

[seb-jean]

The fabbot issue is wrong.

You are right but I did not touch this part of the code.
fabpot.io offers me the following code:

     public function formatDateTime(Environment $env, $date, ?string $dateFormat = 'medium', ?string $timeFormat = 'medium', string $pattern = '', $timezone = null, string $calendar = 'gregorian', string $locale = null): string
     {
-        $date = \twig_date_converter($env, $date, $timezone);
+        $date = twig_date_converter($env, $date, $timezone);
         $formatter = $this->createDateFormatter($locale, $dateFormat, $timeFormat, $pattern, $date->getTimezone(), $calendar);
 
         if (false === $ret = $formatter->format($date)) 

Otherwise, this is the link: https://fabbot.io/patch/twigphp/Twig/3742/cf584f042bf16324db8b8a7a74e067d2e41f03e8/cs.diff

[seb-jean]

It looks like tests are broken.

Tests fail due to line break (\r, \r\n)
I don't see how I could do better to pass the tests.

[fabpot]

Looks good to me.
I made some minor comments.

[fabpot]

These tests are going to break every time there is an update in the underlying dataset. I would suggest only listing some "stable" entries instead.

[fabpot]

@seb-jean Thank you fo all the changes. I'm going to take over the tests changes before merging the PR (I'd like to have it for the next versions that I'm going to release soon).

[fabpot]

Thank you @seb-jean.

[seb-jean]

Thanks to the people who helped me build this PR.