From dc07ca41b7ae9a3045c44210d2d25cdc9b84f0dd Mon Sep 17 00:00:00 2001 From: Simon Taggart Date: Tue, 21 Mar 2023 21:30:48 -0700 Subject: [PATCH] fix(side-modal): fixed side modal position' (#3106) * fix(side-modal): set position to fixed to ensure dialog covers longs scrolling pages * chore: changeset --- .changeset/tasty-timers-change.md | 6 ++++++ .../components/side-modal/src/SideModalContainer.tsx | 1 + 2 files changed, 7 insertions(+) create mode 100644 .changeset/tasty-timers-change.md diff --git a/.changeset/tasty-timers-change.md b/.changeset/tasty-timers-change.md new file mode 100644 index 0000000000..ade1ffbcf5 --- /dev/null +++ b/.changeset/tasty-timers-change.md @@ -0,0 +1,6 @@ +--- +'@twilio-paste/side-modal': patch +'@twilio-paste/core': patch +--- + +[Side Modal] set screen position to fixed to ensure the dialog is always full height in long scrolling screens' diff --git a/packages/paste-core/components/side-modal/src/SideModalContainer.tsx b/packages/paste-core/components/side-modal/src/SideModalContainer.tsx index f96f2f576f..057a4e7951 100644 --- a/packages/paste-core/components/side-modal/src/SideModalContainer.tsx +++ b/packages/paste-core/components/side-modal/src/SideModalContainer.tsx @@ -27,6 +27,7 @@ const BaseSideModalContainer: React.FC