Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underlining on buttons seems like overkill #54

Closed
Matjaxon opened this issue Aug 16, 2019 · 5 comments · Fixed by #147
Labels

Comments

@Matjaxon
Copy link

@Matjaxon Matjaxon commented Aug 16, 2019

I personally find the added underlining on hovered buttons to be unnecessary and jarring. The buttons already change color and have a pointer change. I understand that the underlining was added for accessibility but wouldn't that already be sufficiently covered by the pointer change?

@serifluous

This comment has been minimized.

Copy link
Contributor

@serifluous serifluous commented Aug 20, 2019

Thanks so much for the feedback! We'll take this into account when we iterate next on buttons and discuss with product design teams across Twilio.

For more accessibility context, the pointer change itself won't be sufficient when you're navigating a page with a keyboard only, for example. If you'd like to learn more about our accessibility considerations, definitely let us know. We love talking about accessibility with teams.

You're welcome at office hours any time to discuss this more, too.

@Matjaxon

This comment has been minimized.

Copy link
Author

@Matjaxon Matjaxon commented Aug 21, 2019

I took the screenshot below after tabbing through the paste docs page. Chrome (I'm assuming?) already seems to offer outlining of the active element.

Screen Shot 2019-08-21 at 9 43 21 AM

I would assume there's similar browser support or plugins to address this need better than us adding additional underlining.

@TheSisb

This comment has been minimized.

Copy link
Collaborator

@TheSisb TheSisb commented Oct 7, 2019

Hey @Matjaxon, a delayed update but we are going to remove the underlines from Buttons. Will circle back when that PR is in.

@Innovator007

This comment has been minimized.

Copy link

@Innovator007 Innovator007 commented Oct 15, 2019

I would like to work on this if its open

@SiTaggart

This comment has been minimized.

Copy link
Collaborator

@SiTaggart SiTaggart commented Oct 17, 2019

Thanks for your interest @Innovator007, but I'll be tackling this today

SiTaggart added a commit that referenced this issue Oct 23, 2019
Fixes #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.