Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
I personally find the added underlining on hovered buttons to be unnecessary and jarring. The buttons already change color and have a pointer change. I understand that the underlining was added for accessibility but wouldn't that already be sufficiently covered by the pointer change?
Thanks so much for the feedback! We'll take this into account when we iterate next on buttons and discuss with product design teams across Twilio.
For more accessibility context, the pointer change itself won't be sufficient when you're navigating a page with a keyboard only, for example. If you'd like to learn more about our accessibility considerations, definitely let us know. We love talking about accessibility with teams.
You're welcome at office hours any time to discuss this more, too.