Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix the token formatter tests #102

Merged
merged 1 commit into from Sep 20, 2019

Conversation

@SiTaggart
Copy link
Collaborator

SiTaggart commented Sep 19, 2019

Add back in emotion in the serializer to fix the tests.

Also, throw so the tests actually fail when it errors next time.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.
@SiTaggart SiTaggart requested a review from TheSisb Sep 19, 2019
@now

This comment has been minimized.

Copy link

now bot commented Sep 19, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://paste-git-chore-fix-formatter-tests.twilio-dsys.now.sh

@TheSisb

This comment has been minimized.

Copy link
Collaborator

TheSisb commented Sep 20, 2019

Title:
chore: fix
🤔 lol

@SiTaggart SiTaggart merged commit 1599e1e into master Sep 20, 2019
5 checks passed
5 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
@SiTaggart SiTaggart deleted the chore/fix-formatter-tests branch Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.