Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type-checking fixes #12

Merged
merged 3 commits into from Jul 26, 2019

Conversation

@TheSisb
Copy link
Collaborator

TheSisb commented Jul 26, 2019

  • Add a tsconfig to the design-tokens package so that the type-check command runs in that package's scope
  • Fix website type-checking issues
  • Add yarn type-check:watch command for the website package. Because gatsby-typescript uses babel-typescript (which simply removes typings and compiles), the only type-checking we see is in our editors. It is helpful in some cases to have a separate watcher running during dev.
@now

This comment has been minimized.

Copy link

now bot commented Jul 26, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://paste-git-type-check-fixes.twilio-dsys.now.sh

@TheSisb TheSisb requested a review from SiTaggart Jul 26, 2019
@TheSisb TheSisb self-assigned this Jul 26, 2019
@TheSisb TheSisb force-pushed the type-check-fixes branch from 6e01adc to 9dba403 Jul 26, 2019
@TheSisb TheSisb merged commit be02450 into master Jul 26, 2019
0 of 5 checks passed
0 of 5 checks passed
ci/circleci: build Your tests are queued behind your running builds
Details
ci/circleci: lint Your tests are queued behind your running builds
Details
ci/circleci: prettier CircleCI is running your tests
Details
ci/circleci: test Your tests are queued behind your running builds
Details
now Now is deploying your app
Details
@TheSisb TheSisb deleted the type-check-fixes branch Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.