Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(box): polish and fix #125

Merged
merged 23 commits into from Oct 9, 2019

Conversation

@TheSisb
Copy link
Collaborator

TheSisb commented Oct 7, 2019

So other than the MDX doc site file, this is ready for a review pass. Sorry, this is a big one 馃寠

Changes

  • Made some significant changes to the new @twilio-paste/types package. It now exports zIndex tokens and also all typings support responsive props (so 'space20' or ['space10', 'space20']). Unfortunately for my previous example, width doesn't work in practice due to a bug in Styled System v4. This will be resolved when we upgrade to v5.
  • Updated Box component to correct typings and props taken. Box now takes boxShadow, zIndex, overflow, and all the missing sizing props.
  • Fixed a type bug in the Absolute component after the Box updates.
  • Added dummy breakpoints to Storybook so we can test responsive style props.
  • Updated the Box default story to add all the missing props and added a responsive story.
  • Refactored the @twilio-paste/theme package to export all the theme variants (Console/Sendgrid/Flex/Default). We were duplicating this all over and it was hard keeping everything updated correctly.
  • Midway through my work, the storybook folks decided to nuke a DefinitelyTyped package, so I fix that too.
  • Added the sizes key to @twilio-paste/theme-tokens so we can use responsive sizes in props.
  • BREAKING CHANGE: I removed the shortand m= and p= etc spacing props in favor of the full word variants. I updated all areas where these were used for the long version.
  • Updated the Box documentation page.

Ordinarily I would pull this out into smaller PRs, but since we all jammed on the extraneous stuff together I left it all as one piece.

@now

This comment has been minimized.

Copy link

now bot commented Oct 7, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://paste-git-box-polish-and-docs.twilio-dsys.now.sh

@now now bot temporarily deployed to staging Oct 9, 2019 Inactive
Copy link
Collaborator

SiTaggart left a comment

These are such great improvements

@richbachman

This comment has been minimized.

Copy link
Collaborator

richbachman commented Oct 9, 2019

馃挴

@TheSisb TheSisb merged commit d151bad into master Oct 9, 2019
5 of 6 checks passed
5 of 6 checks passed
ci/circleci: applitools Your tests failed on CircleCI
Details
Semantic Pull Request ready to be squashed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
@TheSisb TheSisb deleted the box/polish-and-docs branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.