Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(icons): delete old icons, add new streamline icons #129
Our icons package needed some serious love. This PR is massive, here's what happened:
High level user-facing stuff:
Icons package janitorial work
Other infra work
I'd like to add more documentation to this package, to make it easier to navigate for future maintainers.
This pull request is being automatically deployed with ZEIT Now (learn more).
I was thinking about that on my Box PR as well. Github topics can only be a single line though. Conventional commits dictates that the title be "fix/etc" and "BREAKING CHANGE" be placed on another line beneath.
One takeaway is that we should isolate BREAKING CHANGES is in PRs so that unrelated packages don't get a major bump for nothing.
After working with @TheSisb, we realized the 1px stroke width means centered icons like the plus icon don't align to full pixels. We're upping icon strokes to 2px.
- huge overhaul to build process - now uses rollup - builds into cjs and esm directories - made the package publishable to npm - moved svg folder out of src, now src only holds react stuff - updated scripts to use new paths and cleaned up the code - programmatically generates rollup config from the icon-list command