Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): a core bundle #138

Merged
merged 6 commits into from Oct 24, 2019
Merged

feat(core): a core bundle #138

merged 6 commits into from Oct 24, 2019

Conversation

@TheSisb
Copy link
Collaborator

TheSisb commented Oct 15, 2019

This PR adds a "Core bundle". This was added to make it easier to start using Paste by combining all of our packages into a single import.

The general approach I took to making this work was by using Lerna to fetch all the packages in our monorepo. I then filter some out and proceed to generate the package.json and index.tsx files.

Open questions:

  • Should any non-core packages be included? (i.e.: theme?)
  • Is where I put the paste-core folder (/packages/paste-core/core-bundle) appropriate?
@now

This comment has been minimized.

Copy link

now bot commented Oct 15, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/twilio-dsys/paste/7c6ka3sb2
🌍 Preview: https://paste-git-core-bundle.twilio-dsys.now.sh

}

// Main
(async () => {

This comment has been minimized.

Copy link
@TheSisb

TheSisb Oct 15, 2019

Author Collaborator

Reading this function explains the main procedure that happens right before a build is triggered on this package.

This comment has been minimized.

Copy link
@richbachman

richbachman Oct 15, 2019

Collaborator

Using private, version, and blacklisted seems like a good way to handle that filter. I like it.

@richbachman

This comment has been minimized.

Copy link
Collaborator

richbachman commented Oct 15, 2019

The /packages/paste-core/core-bundle placement makes sense to me.

@TheSisb TheSisb force-pushed the core-bundle branch from bf4832e to acdd5d4 Oct 24, 2019
@now now bot temporarily deployed to staging Oct 24, 2019 Inactive
@TheSisb TheSisb merged commit f6ab2eb into master Oct 24, 2019
8 checks passed
8 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: applitools Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
scm/applitools No baseline conflicts found! (0 changes found)
Details
tests/applitools No visual tests ran, see "Details" for help
Details
@TheSisb TheSisb deleted the core-bundle branch Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.