Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(card): initial card implementation #145

Merged
merged 31 commits into from Nov 14, 2019

Conversation

@GiantRobots
Copy link
Contributor

GiantRobots commented Oct 18, 2019

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.
@now now bot had a problem deploying to staging Oct 18, 2019 Failure
@now

This comment has been minimized.

Copy link

now bot commented Oct 18, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/twilio-dsys/paste/g6bvphs9l
🌍 Preview: https://paste-git-fork-giantrobots-card.twilio-dsys.now.sh

@now now bot had a problem deploying to staging Oct 18, 2019 Failure
package.json Outdated Show resolved Hide resolved
@SiTaggart

This comment has been minimized.

Copy link
Collaborator

SiTaggart commented Oct 23, 2019

Should the card have a set backgorund color? Right now they are transparent, but I'm wondering if it should be set white? Question for Sean, really.

@now now bot temporarily deployed to staging Oct 23, 2019 Inactive
Copy link
Collaborator

TheSisb left a comment

I think all this package is missing are some tests.

package.json Outdated Show resolved Hide resolved
packages/paste-types/src/DomTypes.ts Show resolved Hide resolved
packages/paste-types/src/DomTypes.ts Outdated Show resolved Hide resolved
packages/paste-core/utilities/absolute/package.json Outdated Show resolved Hide resolved
packages/paste-types/src/DomTypes.ts Show resolved Hide resolved
@now now bot temporarily deployed to staging Nov 13, 2019 Inactive
@now now bot had a problem deploying to staging Nov 13, 2019 Failure
@now now bot had a problem deploying to staging Nov 13, 2019 Failure
@now now bot had a problem deploying to staging Nov 14, 2019 Failure
@now now bot had a problem deploying to staging Nov 14, 2019 Failure
@now now bot temporarily deployed to staging Nov 14, 2019 Inactive
@GiantRobots GiantRobots requested a review from SiTaggart Nov 14, 2019
Copy link
Collaborator

SiTaggart left a comment

Just eslint errors and that final comment and it looks good

@SiTaggart SiTaggart merged commit 9049c5f into twilio-labs:master Nov 14, 2019
8 checks passed
8 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: applitools Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
scm/applitools No baseline conflicts found! (4 changes found)
Details
tests/applitools All visual tests passed! (29 tests)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.