Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: finalise the Text component #151

Merged
merged 3 commits into from Oct 28, 2019

Conversation

@SiTaggart
Copy link
Collaborator

SiTaggart commented Oct 25, 2019

Polish the Text component for production.

  • Update to use styled syatem v5
  • Make the types better
  • Update the use of Text based on any updates
  • Write some basic snapshot tests
@now

This comment has been minimized.

Copy link

now bot commented Oct 25, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/twilio-dsys/paste/gu323jkuk
🌍 Preview: https://paste-git-feat-text-component-polish.twilio-dsys.now.sh

@SiTaggart SiTaggart merged commit b51c272 into master Oct 28, 2019
8 checks passed
8 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: applitools Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
scm/applitools No baseline conflicts found! (1 changes found)
Details
tests/applitools No visual tests ran, see "Details" for help
Details
@SiTaggart SiTaggart deleted the feat/text-component-polish branch Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.