Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: global styles by passing props #169

Merged
merged 2 commits into from Nov 11, 2019
Merged

fix: global styles by passing props #169

merged 2 commits into from Nov 11, 2019

Conversation

@SiTaggart
Copy link
Collaborator

SiTaggart commented Nov 9, 2019

Body styles from global styles not rendered based on props not being passed in,
so there was no theme object to get the token values from.

body styles from global props not rendered based on props not being passed
so there was no theme object to get the token values from
@now

This comment has been minimized.

Copy link

now bot commented Nov 9, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/twilio-dsys/paste/d6l42k8hs
🌍 Preview: https://paste-git-fix-global-styles.twilio-dsys.now.sh

@SiTaggart SiTaggart requested review from TheSisb and richbachman Nov 9, 2019
@SiTaggart SiTaggart merged commit 65c15c0 into master Nov 11, 2019
8 checks passed
8 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: applitools Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
scm/applitools No baseline conflicts found! (25 changes found)
Details
tests/applitools All visual tests passed! (26 tests)
Details
@SiTaggart SiTaggart deleted the fix/global-styles branch Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.