Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design-tokens): change color-text-link token values #172

Merged
merged 8 commits into from Nov 12, 2019

Conversation

@richbachman
Copy link
Collaborator

richbachman commented Nov 11, 2019

  • Updated Console color-text-link values
  • Updated SendGrid color-text-link values
  • Added color-text-icon-* values for Console and SendGrid
  • Updated tests
@now

This comment has been minimized.

Copy link

now bot commented Nov 11, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/twilio-dsys/paste/12wnhvtkx
🌍 Preview: https://paste-git-color-text-link-token-updates.twilio-dsys.now.sh

@serifluous

This comment has been minimized.

Copy link
Contributor

serifluous commented Nov 12, 2019

lgtm!

@TheSisb

This comment has been minimized.

Copy link
Collaborator

TheSisb commented Nov 12, 2019

Can I get some context on why we added color-text-icon-* tokens please? Icons should only accept text colors, and I'm not noticing any deviation in color either

@richbachman

This comment has been minimized.

Copy link
Collaborator Author

richbachman commented Nov 12, 2019

@serifluous will you add some context on the color-text-icon-* additions?

@serifluous

This comment has been minimized.

Copy link
Contributor

serifluous commented Nov 12, 2019

Can I get some context on why we added color-text-icon-* tokens please? Icons should only accept text colors, and I'm not noticing any deviation in color either

Cool ok, didn't realize that. There are no color differences with link. We can remove the icon ones.

@richbachman

This comment has been minimized.

Copy link
Collaborator Author

richbachman commented Nov 12, 2019

@TheSisb @serifluous color-text-icon-* have been removed.

@richbachman richbachman merged commit f0a215c into master Nov 12, 2019
8 checks passed
8 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: applitools Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
scm/applitools No baseline conflicts found! (0 changes found)
Details
tests/applitools All visual tests passed! (26 tests)
Details
@richbachman richbachman deleted the color-text-link-token-updates branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.