Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrading to styled-system v5 #18

Merged
merged 7 commits into from Oct 22, 2019

Conversation

@TheSisb
Copy link
Collaborator

TheSisb commented Jul 30, 2019

1- Update all dependency version numbers
2- Remove the dependency in cases where the code doesn't rely on styled-system
3- Update the code to import {themeGet} from the new package @styled-system/theme-get

Also fixed the typeRoots folder

@TheSisb TheSisb added the Status: WIP label Jul 30, 2019
@now

This comment has been minimized.

Copy link

now bot commented Jul 30, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/twilio-dsys/paste/ht2n5kfuw
🌍 Preview: https://paste-git-styled-system-v5.twilio-dsys.now.sh

@TheSisb TheSisb changed the title [Blocked][WIP] Upgrading styled-system Upgrading to styled-system v5 Aug 20, 2019
@TheSisb TheSisb changed the title Upgrading to styled-system v5 refactor: upgrading to styled-system v5 Aug 20, 2019
@TheSisb TheSisb force-pushed the styled-system-v5 branch from 078aaf4 to bfbb800 Oct 18, 2019
@now now bot had a problem deploying to staging Oct 22, 2019 Failure
@now now bot temporarily deployed to staging Oct 22, 2019 Inactive
@TheSisb TheSisb merged commit 2b3ebd8 into master Oct 22, 2019
6 of 7 checks passed
6 of 7 checks passed
ci/circleci: applitools Your tests failed on CircleCI
Details
Semantic Pull Request ready to be squashed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
tests/applitools No visual tests ran, see "Details" for help
Details
@TheSisb TheSisb deleted the styled-system-v5 branch Oct 22, 2019
@TheSisb TheSisb mentioned this pull request Oct 23, 2019
1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.