Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update destructive button styles to be filled #189

Merged
merged 4 commits into from Nov 16, 2019

Conversation

@SiTaggart
Copy link
Collaborator

SiTaggart commented Nov 15, 2019

Update the destructive buttons to be outlined filled.

also get storybook serving colfax correctly for the SG theme

@now

This comment has been minimized.

Copy link

now bot commented Nov 15, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/twilio-dsys/paste/9dmp54w9u
🌍 Preview: https://paste-git-fix-buttondestructive-button-styles.twilio-dsys.now.sh

return (
<Theme.Provider theme={this.state.theme}>
<Global styles={globalStyles} />
<Box padding="space40">{this.props.children}</Box>

This comment has been minimized.

Copy link
@TheSisb

TheSisb Nov 15, 2019

Collaborator

Thank you 👍

Copy link
Collaborator

TheSisb left a comment

image
Did you mean 'filled'?

package.json Outdated Show resolved Hide resolved
@SiTaggart SiTaggart force-pushed the fix/button/destructive-button-styles branch from 4161ede to 4571971 Nov 15, 2019
@now now bot temporarily deployed to staging Nov 15, 2019 Inactive
@now now bot temporarily deployed to staging Nov 15, 2019 Inactive
@SiTaggart SiTaggart merged commit c29b7ca into master Nov 16, 2019
8 checks passed
8 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: applitools Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
scm/applitools No baseline conflicts found! (28 changes found)
Details
tests/applitools All visual tests passed! (29 tests)
Details
@SiTaggart SiTaggart deleted the fix/button/destructive-button-styles branch Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.