Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tokens page #19

Merged
merged 6 commits into from Aug 7, 2019

Conversation

@SiTaggart
Copy link
Collaborator

SiTaggart commented Aug 1, 2019

I judge this to be getting out of control, so lets review and merge where I am so I can finish up extra functionality in other PRs

  • Basic outline of the tokens page. It's generated based on the graphQL data we get from the tokens json file
  • Updated Box and Text props a bunch to make them more usable in my examples.
  • Token filter is a fairly simlple couple of filter and a state hook.
@now

This comment has been minimized.

Copy link

now bot commented Aug 1, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://paste-git-feat-token-page.twilio-dsys.now.sh

@richbachman

This comment has been minimized.

Copy link
Collaborator

richbachman commented Aug 7, 2019

Along with Shadi's comments, I think this looks good to me.

@SiTaggart SiTaggart requested review from TheSisb and richbachman Aug 7, 2019
@@ -19,11 +19,11 @@ const BASE_PLUGINS = ['macros', '@babel/proposal-class-properties', '@babel/prop
module.exports = {
env: {
production: {
presets: getPresets(true),
presets: getPresets(false),

This comment has been minimized.

Copy link
@SiTaggart

SiTaggart Aug 7, 2019

Author Collaborator

@TheSisb Swapping these as I think they are the wrong way round.

This comment has been minimized.

Copy link
@TheSisb

TheSisb Aug 7, 2019

Collaborator

Good catch! Could you swap the one in ./.storybook too please? 🙏

Copy link
Collaborator

TheSisb left a comment

🚢

@TheSisb
TheSisb approved these changes Aug 7, 2019
@SiTaggart SiTaggart merged commit 878d3c5 into master Aug 7, 2019
5 checks passed
5 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
@SiTaggart SiTaggart deleted the feat/token-page branch Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.