New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): add alarms, text format, event streams and unsorted icons #1957
Conversation
🦋 Changeset detectedLatest commit: 9b9a2e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for paste-theme-designer ready! 🔨 Explore the source changes: 9b9a2e5 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-theme-designer/deploys/6171e009ee523500077dcf7b 😎 Browse the preview: https://deploy-preview-1957--paste-theme-designer.netlify.app |
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: 9b9a2e5 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/6171e0093a44760007257795 😎 Browse the preview: https://deploy-preview-1957--paste-docs.netlify.app |
Size Change: -9 B (0%) Total Size: 532 kB
ℹ️ View Unchanged
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
fill="none" | ||
viewBox="0 0 20 20" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the only changes in this file is moving viewBox and clipRule attributes to different lines. Is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does seem weird that the SVG was out of sync with the React icon svg source. Wonder how that happened? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We reformatted this icon a while back and this is the reexport.
ProductAlarmsIcon
,TextFormatIcon
ProductEventStreamsIcon
andUnsortedIcon