Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change heading variants #196

Merged
merged 8 commits into from Nov 21, 2019

Conversation

@richbachman
Copy link
Collaborator

richbachman commented Nov 20, 2019

  • Changed headingStyles to headingVariants
  • Mapped headingVariants to use our scale system -> 10 being largest and 60 being smallest.
  • Updated docs site to use new headingVariants
@now

This comment has been minimized.

Copy link

now bot commented Nov 20, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/twilio-dsys/paste/1oyyrjmc3
🌍 Preview: https://paste-git-fix-heading-variants.twilio-dsys.now.sh

Copy link
Collaborator

SiTaggart left a comment

Just need to match the comment to the value

packages/paste-core/components/heading/src/index.tsx Outdated Show resolved Hide resolved
@SiTaggart

This comment has been minimized.

Copy link
Collaborator

SiTaggart commented Nov 21, 2019

How are you going to keep the docs up to date with this new API change,m if the docs are in another PR?

@richbachman

This comment has been minimized.

Copy link
Collaborator Author

richbachman commented Nov 21, 2019

@SiTaggart the plan is to merge this PR, then go back and edit the docs in #192 so they align.

Co-Authored-By: Simon Taggart <staggart@twilio.com>
@now now bot temporarily deployed to staging Nov 21, 2019 Inactive
@richbachman richbachman merged commit 061cc3e into master Nov 21, 2019
6 of 7 checks passed
6 of 7 checks passed
ci/circleci: applitools CircleCI is running your tests
Details
Semantic Pull Request ready to be squashed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
tests/applitools No visual tests ran, see "Details" for help
Details
@richbachman richbachman deleted the fix/heading-variants branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.