Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run eslint across the right files and fix any issues that arise. #21

Merged
merged 4 commits into from Aug 6, 2019

Conversation

@SiTaggart
Copy link
Collaborator

SiTaggart commented Aug 6, 2019

Eslint was only running on maybe 4 files. Fixing up the path and adjusting the ignore made eslint run on every file we care about.

Fixed up some of the eslint errors that we in the codebase already but not being linted.

@SiTaggart SiTaggart requested a review from TheSisb Aug 6, 2019
@now

This comment has been minimized.

Copy link

now bot commented Aug 6, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://paste-git-fix-eslint-files.twilio-dsys.now.sh

.eslintignore Outdated Show resolved Hide resolved
.eslintrc.js Show resolved Hide resolved
@TheSisb
TheSisb approved these changes Aug 6, 2019
@SiTaggart SiTaggart merged commit 2fcc872 into master Aug 6, 2019
5 checks passed
5 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
@SiTaggart SiTaggart deleted the fix/eslint-files branch Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.