Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): change "color-text-inverse-weak" for a11y #218

Merged
merged 5 commits into from Dec 5, 2019

Conversation

@serifluous
Copy link
Contributor

serifluous commented Dec 4, 2019

  • In console theme, color-text-inverse-weak changed to palette-gray-50 to pass AA contrast with color-background-inverse

It didn't originally pass AA as its original value of palette-gray-60.

- [x] In console theme, `color-text-inverse-weak` changed to `palette-gray-50` to pass AA contrast with `color-background-inverse`

It didn't originally pass AA as its original value of `palette-gray-60`.
@now

This comment has been minimized.

Copy link

now bot commented Dec 4, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/twilio-dsys/paste/aykptv9so
🌍 Preview: https://paste-git-fix-color-text-inverse-weak-a11y.twilio-dsys.now.sh

@serifluous serifluous requested a review from TheSisb Dec 4, 2019
@@ -16,7 +16,7 @@ props:
value: "{!palette-gray-0}"
comment: Inverse text color for dark backgrounds
color-text-inverse-weak:
value: "{!palette-gray-60}"
value: "{!palette-gray-50}"
comment: Weak inverse text color for dark backgrounds

This comment has been minimized.

Copy link
@TheSisb

TheSisb Dec 4, 2019

Collaborator

Are there any notes or gotchas related to this change we should add in this comment line?

This comment has been minimized.

Copy link
@serifluous

serifluous Dec 4, 2019

Author Contributor

Do you mean whether we should change the comment to, e.g., "Weak inverse text color for dark backgrounds. Must pass AA color contrast with color-background-inverse"?

Or did you have something else in mind?

This comment has been minimized.

Copy link
@TheSisb

TheSisb Dec 4, 2019

Collaborator

Nothing specific in mind, just wanted to make sure to ask. What you wrote above seems good to me!

@now now bot temporarily deployed to staging Dec 5, 2019 Inactive
Copy link
Collaborator

TheSisb left a comment

Just waiting for the comment tweak and lgtm

@now now bot temporarily deployed to staging Dec 5, 2019 Inactive
@TheSisb
TheSisb approved these changes Dec 5, 2019
@serifluous serifluous merged commit c29de58 into master Dec 5, 2019
8 checks passed
8 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: applitools Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
scm/applitools No baseline conflicts found! (0 changes found)
Details
tests/applitools All visual tests passed! (29 tests)
Details
@serifluous serifluous deleted the fix/color-text-inverse-weak-a11y branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.