Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): display text tokens on the correct inverse bg color #220

Merged
merged 1 commit into from Dec 5, 2019

Conversation

@SiTaggart
Copy link
Collaborator

SiTaggart commented Dec 5, 2019

Realised we were displaying "light" text colors on the brand background instead of the actual inverse background color as intended in real life.

Fixed

@now

This comment has been minimized.

Copy link

now bot commented Dec 5, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/twilio-dsys/paste/h0gc6iz83
🌍 Preview: https://paste-git-fix-websiteuse-correct-inverse-color.twilio-dsys.now.sh

@TheSisb
TheSisb approved these changes Dec 5, 2019
Copy link
Collaborator

TheSisb left a comment

lol

@SiTaggart SiTaggart force-pushed the fix/website/use-correct-inverse-color branch from bbd809b to a5d069e Dec 5, 2019
@now now bot requested a deployment to staging Dec 5, 2019 Pending
@SiTaggart SiTaggart merged commit 3aaa0f8 into master Dec 5, 2019
8 checks passed
8 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: applitools Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
scm/applitools No baseline conflicts found! (0 changes found)
Details
tests/applitools All visual tests passed! (29 tests)
Details
@SiTaggart SiTaggart deleted the fix/website/use-correct-inverse-color branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.