Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add prop-types package, add description, bump types #234

Merged
merged 1 commit into from Dec 18, 2019

Conversation

@richbachman
Copy link
Collaborator

richbachman commented Dec 17, 2019

  • Add missing prop-types package
  • Bump types version
  • Add description
@now

This comment has been minimized.

Copy link

now bot commented Dec 17, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/twilio-dsys/paste/n4mz3dv7n
🌍 Preview: https://paste-git-fix-flexadd-proptypes.twilio-dsys.now.sh

@SiTaggart

This comment has been minimized.

Copy link
Collaborator

SiTaggart commented Dec 17, 2019

Kind of weird that it built... 🤔

@richbachman

This comment has been minimized.

Copy link
Collaborator Author

richbachman commented Dec 17, 2019

I thought so as well. Didn't catch it until I was importing into the docs site, and it was blowing that build up.

@richbachman

This comment has been minimized.

Copy link
Collaborator Author

richbachman commented Dec 17, 2019

Talked to @TheSisb about this. The original build worked because Prop-Types was already in the node_modules from other component builds. Once I imported into the website project, Prop-Types didn't come with it.

@richbachman richbachman merged commit c97d878 into master Dec 18, 2019
8 checks passed
8 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: applitools Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
scm/applitools No baseline conflicts found! (0 changes found)
Details
tests/applitools All visual tests passed! (54 tests)
Details
@richbachman richbachman deleted the fix/flex/add-proptypes branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.