Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): add CopyIcon #235

Merged
merged 3 commits into from Dec 18, 2019
Merged

Conversation

@hharnisc
Copy link
Contributor

hharnisc commented Dec 18, 2019

Adds the CopyIcon with the same SVG as the internal react component library

image

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.
hharnisch
@now

This comment has been minimized.

Copy link

now bot commented Dec 18, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/twilio-dsys/paste/6nuteh0x0
🌍 Preview: https://paste-git-fork-hharnisc-feat-add-copy-icon.twilio-dsys.now.sh

import {LoadingIcon} from './src/LoadingIcon';
import {PlusIcon} from './src/PlusIcon';

interface IconProps {
title?: string;
decorative?: boolean;

This comment has been minimized.

Copy link
@hharnisc

hharnisc Dec 18, 2019

Author Contributor

I followed the instructions outlined here: https://github.com/twilio-labs/paste/blob/master/packages/paste-icons/README.md#how-can-i-contribute-icons

Interesting the tool removed the ?

This comment has been minimized.

Copy link
@TheSisb

TheSisb Dec 18, 2019

Collaborator

Yup this change is good. The ? there was an oversight.

@@ -0,0 +1,43 @@
/**
* This file was automatically generated with @twilio-labs/svg-to-react

This comment has been minimized.

Copy link
@hharnisc

hharnisc Dec 18, 2019

Author Contributor

This was very smooth!

This comment has been minimized.

Copy link
@TheSisb

TheSisb Dec 18, 2019

Collaborator

Thanks! :D

@serifluous

This comment has been minimized.

Copy link
Contributor

serifluous commented Dec 18, 2019

Hey @hharnisc! I'm going to send you an updated SVG tonight. We're going to make the square in the icon more square.

Thanks for being proactive on this!

@hharnisc

This comment has been minimized.

Copy link
Contributor Author

hharnisc commented Dec 18, 2019

Sounds great @serifluous 🙌 I'll update the PR with the new SVG

@hharnisc

This comment has been minimized.

Copy link
Contributor Author

hharnisc commented Dec 18, 2019

@TheSisb I updated the CopyIcon with the approved design (thank you @serifluous 🙌 )

@TheSisb TheSisb merged commit d51d0d2 into twilio-labs:master Dec 18, 2019
8 checks passed
8 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: applitools Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
scm/applitools No baseline conflicts found! (1 changes found)
Details
tests/applitools All visual tests passed! (54 tests)
Details
@hharnisc hharnisc deleted the hharnisc:feat/add-copy-icon branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.