Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Absolute component #24

Merged
merged 5 commits into from Aug 7, 2019

Conversation

@TheSisb
Copy link
Collaborator

TheSisb commented Aug 6, 2019

  • Add an Absolute utility type component
  • Swap Button's SpinnerWrapper to use this new component.
  • Adds an ESLint resolver for more stable builds against monorepo packages on CI
@TheSisb TheSisb requested a review from SiTaggart Aug 6, 2019
@now

This comment has been minimized.

Copy link

now bot commented Aug 6, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://paste-git-absolute-component.twilio-dsys.now.sh

@now now bot temporarily deployed to staging Aug 6, 2019 Inactive
- persist_to_workspace:
root: ~/
paths:
- repo/packages
- tools/.cache

This comment has been minimized.

Copy link
@SiTaggart

SiTaggart Aug 7, 2019

Collaborator

This might need to be repo/tools/.cache... I had a bit of a time getting this right just so you're prepared for a bit of trial and error

This comment has been minimized.

Copy link
@TheSisb

TheSisb Aug 7, 2019

Author Collaborator

thanks

@TheSisb TheSisb force-pushed the absolute-component branch from fb53195 to 4e5e99d Aug 7, 2019
@TheSisb TheSisb force-pushed the absolute-component branch from 4e5e99d to 6a2ee43 Aug 7, 2019
const resolve = require('resolve');
const cachedPackages = require('../tools/.cache/packages.json');

exports.interfaceVersion = 2;

This comment has been minimized.

Copy link
@SiTaggart

SiTaggart Aug 7, 2019

Collaborator

is this an eslint thing?

This comment has been minimized.

Copy link
@TheSisb

TheSisb Aug 7, 2019

Author Collaborator

Yeah, their resolver spec needs it: https://github.com/benmosher/eslint-plugin-import/tree/master/resolvers

image

Every JS library wants to do things in their own way :/

@TheSisb TheSisb merged commit ff2f1d9 into master Aug 7, 2019
4 checks passed
4 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
@TheSisb TheSisb deleted the absolute-component branch Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.