Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): Callout component #25

Merged
merged 12 commits into from Aug 7, 2019

Conversation

@richbachman
Copy link
Collaborator

richbachman commented Aug 6, 2019

Code and examples for Callout component.

After discussion with Jason, there should be three variants. Right now those are primary, secondary, and warning. Primary is also the default/fallback variant. Those can be adjusted after 0.1 as needed. Callout uses the Box component, and also includes an optional CalloutTitle component that uses our Text component. No icon version is needed at this time.

Colors will need to be adjusted after a future meeting with Jason.

NOTE:
After work from @SiTaggart gets merged into master we should move the borderColorPartial function to use prop tokens, and out of the styles.ts file.

@richbachman richbachman requested review from SiTaggart and TheSisb Aug 6, 2019
@now

This comment has been minimized.

Copy link

now bot commented Aug 6, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://paste-git-dsys-1060.twilio-dsys.now.sh

@richbachman richbachman changed the title feat(website): [DSYS-1060] Callout component feat(website): Callout component Aug 6, 2019
@now now bot temporarily deployed to staging Aug 6, 2019 Inactive
Copy link
Collaborator

TheSisb left a comment

👍 on top of Simon's comments

@TheSisb
TheSisb approved these changes Aug 7, 2019
@richbachman richbachman merged commit e4a3d00 into master Aug 7, 2019
5 checks passed
5 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
@richbachman richbachman deleted the DSYS-1060 branch Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.