Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): adding some polish #67

Merged
merged 11 commits into from Aug 26, 2019

Conversation

@TheSisb
Copy link
Collaborator

TheSisb commented Aug 23, 2019

  • Make Button component select the correct defauly size based on variant or child passed
  • Fix error message in Button component
  • Give Button and all Icons a displayName
  • Make Button bg color transition nicely
  • Fix Button as link font-size
  • Fix spacing between Buttons in LivePreview on doc site

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.
@TheSisb TheSisb added the Status: WIP label Aug 23, 2019
@now

This comment has been minimized.

Copy link

now bot commented Aug 23, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://paste-git-button-polish.twilio-dsys.now.sh

@now now bot temporarily deployed to staging Aug 23, 2019 Inactive
@now now bot temporarily deployed to staging Aug 23, 2019 Inactive
@now now bot requested a deployment to staging Aug 23, 2019 Abandoned
TheSisb added 2 commits Aug 23, 2019
- fix thrown error message typo
- pick the correct default 'size=icon' prop if there's only 1 icon child
- make size prop optionable
- add a displayName
@now now bot temporarily deployed to staging Aug 23, 2019 Inactive
@now now bot temporarily deployed to staging Aug 23, 2019 Inactive
@TheSisb TheSisb requested a review from twilio-labs/design-systems Aug 23, 2019
@TheSisb TheSisb self-assigned this Aug 23, 2019
@TheSisb TheSisb merged commit 2644657 into master Aug 26, 2019
5 checks passed
5 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
@TheSisb TheSisb deleted the button-polish branch Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.