Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): changed primary, secondary, destructive styles #72

Merged
merged 3 commits into from Aug 29, 2019

Conversation

@richbachman
Copy link
Collaborator

richbachman commented Aug 27, 2019

Primary, Secondary, and Destructive button styles changes:

  • Fixed hover states to use correct colors
  • Fixed focus states to use correct colors
  • Fixed active states to use correct colors
  • Fixed border-width
  • Fixed font-weight

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.
@now

This comment has been minimized.

Copy link

now bot commented Aug 27, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://paste-git-adjust-button-styles.twilio-dsys.now.sh

@serifluous

This comment has been minimized.

Copy link
Contributor

serifluous commented Aug 28, 2019

Seems like on the hover state for secondary, the text and border are different colors, though they should be the same. @two24studios can you check?

@richbachman

This comment has been minimized.

Copy link
Collaborator Author

richbachman commented Aug 28, 2019

@serifluous I think thats because I split the two PRs I worked on yesterday. This PR doesn't include the code from this PR: #71

Once that is merged into master, I'll merge master back into this branch for review.

@richbachman richbachman merged commit 670faef into master Aug 29, 2019
5 checks passed
5 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
@richbachman richbachman deleted the adjust-button-styles branch Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.