Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tokens): correct the box shadow tokens category and type #95

Merged
merged 4 commits into from Sep 13, 2019

Conversation

@SiTaggart
Copy link
Collaborator

SiTaggart commented Sep 12, 2019

I had the type and category round the wrong way, switching it around whilst I can without being too much of a big change

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.
@now

This comment has been minimized.

Copy link

now bot commented Sep 12, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://paste-git-fix-box-shadow-token-cat-type.twilio-dsys.now.sh

@SiTaggart SiTaggart changed the title Fix/box shadow token cat type Fix(tokens): correct the box shadow tokens category and type Sep 12, 2019
@SiTaggart SiTaggart requested a review from TheSisb Sep 12, 2019
@@ -29,6 +29,7 @@ const widths = {
const heights = {
...sizings,
};
const shadows = {...boxShadows};

This comment has been minimized.

Copy link
@TheSisb

TheSisb Sep 12, 2019

Collaborator

Why do we need to clone this vs something like

export const DefaultTheme = {
  ...
  shadows: boxShadows,
  ...
};

This comment has been minimized.

Copy link
@SiTaggart

SiTaggart Sep 12, 2019

Author Collaborator

Because I didn't think of it 😛

@TheSisb TheSisb changed the title Fix(tokens): correct the box shadow tokens category and type fix(tokens): correct the box shadow tokens category and type Sep 12, 2019
@SiTaggart SiTaggart merged commit fe0f946 into master Sep 13, 2019
5 checks passed
5 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
@SiTaggart SiTaggart deleted the fix/box-shadow-token-cat-type branch Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.