New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made dial 'whisper' optional. #189

Merged
merged 1 commit into from Jan 23, 2012

Conversation

Projects
None yet
2 participants
@tjlytle
Contributor

tjlytle commented Jan 23, 2012

I think I've seen a few requests for this, and I had a client that needed it. It defaults to enabled, maintaining original behavior, but allowing the whisper to be turned off.

Made dial 'whisper' optional.
Defaults to enabled, maintaining original behaviour.
@Gipetto

This comment has been minimized.

Show comment
Hide comment
@Gipetto

Gipetto Jan 23, 2012

Member

I've seen a few requests for this as well. I'll check this out today.

Member

Gipetto commented Jan 23, 2012

I've seen a few requests for this as well. I'll check this out today.

Gipetto added a commit that referenced this pull request Jan 23, 2012

Merge pull request #189 from FrontStream/develop
Made dial 'whisper' optional.

@Gipetto Gipetto merged commit e948cf8 into twilio:develop Jan 23, 2012

@Gipetto

This comment has been minimized.

Show comment
Hide comment
@Gipetto

Gipetto Jan 23, 2012

Member

Tested and confirmed as "hot diggity".

Member

Gipetto commented Jan 23, 2012

Tested and confirmed as "hot diggity".

@tjlytle

This comment has been minimized.

Show comment
Hide comment
@tjlytle

tjlytle Jan 23, 2012

Contributor

Cool. Estimate on next release to master? No rush, just want to know if I should put my client on develop, or just wait a few days and pull the latest release.

Contributor

tjlytle commented Jan 23, 2012

Cool. Estimate on next release to master? No rush, just want to know if I should put my client on develop, or just wait a few days and pull the latest release.

@Gipetto

This comment has been minimized.

Show comment
Hide comment
@Gipetto

Gipetto Jan 23, 2012

Member

I need to wrap up support on a sub-tenant style loading issue that popped up while handling a different issue and then I can push this out. I'm hoping by the end of the week at the latest.

Member

Gipetto commented Jan 23, 2012

I need to wrap up support on a sub-tenant style loading issue that popped up while handling a different issue and then I can push this out. I'm hoping by the end of the week at the latest.

@Gipetto

This comment has been minimized.

Show comment
Hide comment
@Gipetto

Gipetto Jan 26, 2012

Member

This code is now live in 1.2.4

Member

Gipetto commented Jan 26, 2012

This code is now live in 1.2.4

@Gipetto

This comment has been minimized.

Show comment
Hide comment
@Gipetto

Gipetto Apr 25, 2012

Member

Hm, just got a notification that the whisper toggle is not working. I an reproduce and am investigating this.
https://getsatisfaction.com/openvbx/topics/calls_not_being_announced_whisper_on_new_installation

Member

Gipetto commented Apr 25, 2012

Hm, just got a notification that the whisper toggle is not working. I an reproduce and am investigating this.
https://getsatisfaction.com/openvbx/topics/calls_not_being_announced_whisper_on_new_installation

@Gipetto

This comment has been minimized.

Show comment
Hide comment
@Gipetto

Gipetto Apr 25, 2012

Member

See GetSat thread: probably not gonna fix right away.

Member

Gipetto commented Apr 25, 2012

See GetSat thread: probably not gonna fix right away.

@tjlytle

This comment has been minimized.

Show comment
Hide comment
@tjlytle

tjlytle Apr 25, 2012

Contributor

If I read that correctly, it's not actually an issue with the toggle, just something that was never supported (but with the toggle UI, gives the impression that it should be).

Contributor

tjlytle commented Apr 25, 2012

If I read that correctly, it's not actually an issue with the toggle, just something that was never supported (but with the toggle UI, gives the impression that it should be).

@Gipetto

This comment has been minimized.

Show comment
Hide comment
@Gipetto

Gipetto Apr 25, 2012

Member

Yup.

Member

Gipetto commented Apr 25, 2012

Yup.

@Gipetto

This comment has been minimized.

Show comment
Hide comment
@Gipetto

Gipetto Apr 25, 2012

Member

I just re-read the question and he is dialing a user. The only way that can fail, from browsing the code, is if the user has no first name. If that's not the case then it'll require more investigation.

Member

Gipetto commented Apr 25, 2012

I just re-read the question and he is dialing a user. The only way that can fail, from browsing the code, is if the user has no first name. If that's not the case then it'll require more investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment