Skip to content

Made dial 'whisper' optional. #189

Merged
merged 1 commit into from Jan 23, 2012

2 participants

@tjlytle
tjlytle commented Jan 23, 2012

I think I've seen a few requests for this, and I had a client that needed it. It defaults to enabled, maintaining original behavior, but allowing the whisper to be turned off.

@tjlytle tjlytle Made dial 'whisper' optional.
Defaults to enabled, maintaining original behaviour.
941c15a
@Gipetto
Twilio member
Gipetto commented Jan 23, 2012

I've seen a few requests for this as well. I'll check this out today.

@Gipetto Gipetto merged commit e948cf8 into twilio:develop Jan 23, 2012
@Gipetto
Twilio member
Gipetto commented Jan 23, 2012

Tested and confirmed as "hot diggity".

@tjlytle
tjlytle commented Jan 23, 2012

Cool. Estimate on next release to master? No rush, just want to know if I should put my client on develop, or just wait a few days and pull the latest release.

@Gipetto
Twilio member
Gipetto commented Jan 23, 2012

I need to wrap up support on a sub-tenant style loading issue that popped up while handling a different issue and then I can push this out. I'm hoping by the end of the week at the latest.

@Gipetto
Twilio member
Gipetto commented Jan 26, 2012

This code is now live in 1.2.4

@Gipetto
Twilio member
Gipetto commented Apr 25, 2012

Hm, just got a notification that the whisper toggle is not working. I an reproduce and am investigating this.
https://getsatisfaction.com/openvbx/topics/calls_not_being_announced_whisper_on_new_installation

@Gipetto
Twilio member
Gipetto commented Apr 25, 2012

See GetSat thread: probably not gonna fix right away.

@tjlytle
tjlytle commented Apr 25, 2012

If I read that correctly, it's not actually an issue with the toggle, just something that was never supported (but with the toggle UI, gives the impression that it should be).

@Gipetto
Twilio member
Gipetto commented Apr 25, 2012

Yup.

@Gipetto
Twilio member
Gipetto commented Apr 25, 2012

I just re-read the question and he is dialing a user. The only way that can fail, from browsing the code, is if the user has no first name. If that's not the case then it'll require more investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.