Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven-compiler-plugin 3.8.1 #11

Merged
merged 1 commit into from Sep 2, 2019

Conversation

@sullis
Copy link
Contributor

commented Aug 31, 2019

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.
@sullis

This comment has been minimized.

Copy link
Contributor Author

commented Aug 31, 2019

@sullis

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

Background:

maven-compiler-plugin 2.3.2 was released in September 2010.
maven-compiler-plugin 3.8.1 was released in May 2019.

Version 3.8.1 release notes:
https://blogs.apache.org/maven/entry/apache-maven-compiler-plugin-version1

Version 3.8.1 is the latest release. It is compatible with Java 8 and beyond.

@blast-hardcheese

@blast-hardcheese
Copy link
Collaborator

left a comment

Gotcha, just wondering how you even found this. LGTM.

@blast-hardcheese blast-hardcheese merged commit ac72477 into twilio:master Sep 2, 2019

@sullis sullis deleted the sullis:compiler-plugin-3.8.1 branch Sep 3, 2019

@sullis

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

FYI: two weeks ago, I made a similar fix in the [openapi-generator] project:

OpenAPITools/openapi-generator#3711

Also: I made this fix in the AWS SDK v2 project:

aws/aws-sdk-java-v2#1383

@sullis

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

related PR in [sendgrid-java]: sendgrid/sendgrid-java#574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.