New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File upload reference leak #109

Closed
blast-hardcheese opened this Issue Oct 9, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@blast-hardcheese
Collaborator

blast-hardcheese commented Oct 9, 2018

The AtomicReference that keeps track of written Files (https://github.com/twilio/guardrail/blob/master/modules/codegen/src/main/scala/com/twilio/guardrail/generators/AkkaHttpServerGenerator.scala#L669) is created outside the entity directive in generated servers.

This causes File references to accumulate in that list, and every time any request completes, the entire list is walked and all file references are deleted. In the event of a name collision between files, in-progress files will be deleted prematurely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment