New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing helpful error messages #150

Merged
merged 8 commits into from Jan 8, 2019

Conversation

Projects
None yet
2 participants
@blast-hardcheese
Copy link
Collaborator

blast-hardcheese commented Jan 6, 2019

  • Added error messages to polymorphic discriminators (previous error: scala.MatchError: foo (of class java.lang.String))
  • Exposed underlying circe decoding errors
  • Removed incorrect usage of NoContentException

Initial work towards #148, actually exposing validation errors in clients and servers. Customization will be more tricky, still need to think about how that will work.

@blast-hardcheese

This comment has been minimized.

Copy link
Collaborator

blast-hardcheese commented Jan 7, 2019

This flips the needle to overcommunicating client failures, which may be undesirable for consumers looking for security through obscurity. If this is your use case, using akka-http's mapResponse directive to suppress these messages.

@blast-hardcheese blast-hardcheese force-pushed the blast-hardcheese:helpful-error-messages branch from a20ad9a to f8f2f39 Jan 7, 2019

@blast-hardcheese blast-hardcheese force-pushed the blast-hardcheese:helpful-error-messages branch from f8f2f39 to 7f97cf3 Jan 8, 2019

@blast-hardcheese blast-hardcheese merged commit 082cc15 into twilio:master Jan 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@blast-hardcheese blast-hardcheese deleted the blast-hardcheese:helpful-error-messages branch Jan 8, 2019

@sledorze

This comment has been minimized.

Copy link

sledorze commented Jan 8, 2019

@blast-hardcheese thanks a lot!

@blast-hardcheese

This comment has been minimized.

Copy link
Collaborator

blast-hardcheese commented Jan 9, 2019

@sledorze You're welcome! 0.41.4 is now available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment