Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cats effect Async instead of Effect #224

Merged
merged 2 commits into from Apr 3, 2019

Conversation

Projects
None yet
2 participants
@hanny24
Copy link

commented Apr 2, 2019

Both http4s generated server and client require implicit instance of Effect[F]. This seems as way too powerful constraint that limits certain use cases. One example would be type F[T] = ReaderT[IO, Context, T]. It does not have instance of Effect. If we were to change the requirement from Effect to Async, it would remove this limitation.

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Jan Strnad added some commits Apr 2, 2019

@hanny24

This comment has been minimized.

Copy link
Author

commented Apr 2, 2019

@blast-hardcheese
Copy link
Collaborator

left a comment

From my reading of cats' Effect, Sync, and Async, it seems as though this won't impact existing codebases, is that correct?

@hanny24

This comment has been minimized.

Copy link
Author

commented Apr 3, 2019

Yes, existing codebases continue to work just fine as every Effect is also Async.

@blast-hardcheese

This comment has been minimized.

Copy link
Collaborator

commented Apr 3, 2019

Very cool, thanks for the clarification.

@blast-hardcheese blast-hardcheese merged commit 4eb8ad6 into twilio:master Apr 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.