Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Java class definitions from resources in a safer manner #226

Merged
merged 1 commit into from Apr 4, 2019

Conversation

Projects
None yet
2 participants
@kelnos
Copy link
Member

commented Apr 3, 2019

Makes the source-file-in-resources loading generic (so I can use it easily from other places), and safer (wrap with Try and return Target instead), and returns a SupportDefinition so we can pull import lists from the source file itself.

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@kelnos kelnos requested a review from blast-hardcheese Apr 3, 2019

@kelnos

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

@blast-hardcheese any objections to merging?

@kelnos kelnos force-pushed the kelnos:java-resource-loading-refactor branch from 12fba18 to 25763f1 Apr 4, 2019

@kelnos kelnos merged commit 81d08f8 into twilio:master Apr 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kelnos kelnos deleted the kelnos:java-resource-loading-refactor branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.