Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unescape property names when building with*() methods for POJOs #269

Merged
merged 1 commit into from May 1, 2019

Conversation

Projects
None yet
2 participants
@kelnos
Copy link
Member

commented May 1, 2019

If a property name is a reserved word, it'll get escaped with an underscore appended. But when we capitalize that word and prepend "with", it's no longer reserved and doesn't need the ugly trailing underscore anymore.

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.
Unescape property names when building with*() methods for POJOs
If a property name is a reserved word, it'll get escaped with an
underscore appended.  But when we capitalize that word and prepend
"with", it's no longer reserved and doesn't need the ugly trailing
underscore anymore.

@kelnos kelnos requested a review from blast-hardcheese May 1, 2019

@kelnos kelnos merged commit 893e003 into twilio:master May 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kelnos kelnos deleted the kelnos:jackson-unescape-with-method-names branch May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.