Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security support for Dropwizard #274

Closed
wants to merge 7 commits into from

Conversation

Projects
None yet
2 participants
@kelnos
Copy link
Member

commented May 2, 2019

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@kelnos kelnos requested a review from blast-hardcheese May 2, 2019

}

case scheme @ HttpSecurityScheme(authScheme, _) =>
authScheme match {

This comment has been minimized.

Copy link
@blast-hardcheese

blast-hardcheese May 2, 2019

Collaborator

case sensitivity?

This comment has been minimized.

Copy link
@kelnos

kelnos May 2, 2019

Author Member

The spec doesn't seem to suggest anything but lowercase is allowed.

@kelnos

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

Note that it's not 100% critical that this one go into the next release; if it's getting to be too much to review all these, I'm fine with this one missing the cut-off.

@kelnos kelnos force-pushed the kelnos:dw-authorization-support branch 2 times, most recently from f8c611a to 219c0b2 May 2, 2019

@blast-hardcheese

This comment has been minimized.

Copy link
Collaborator

commented May 2, 2019

we do have a lot of changes slated for this release. I'm interested in #222 and #259, as @tomasherman has been working diligently on those for a while. If we can wrap up the rest of the stuff that's bugfix, that'd be appreciated before starting anew on new feature work.

@kelnos kelnos force-pushed the kelnos:dw-authorization-support branch from 219c0b2 to c61aa33 May 3, 2019

@kelnos kelnos force-pushed the kelnos:dw-authorization-support branch from c61aa33 to d50fdd8 May 13, 2019

@kelnos

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

Realized I've been doing this the wrong way for DW. Gonna close this until I have it worked out.

@kelnos kelnos closed this May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.