Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copypasta in JacksonGenerator causing maps to be lists #281

Merged
merged 1 commit into from May 4, 2019

Conversation

Projects
None yet
2 participants
@kelnos
Copy link
Member

commented May 4, 2019

Also parse both in a safer way that makes it more clear where errors lie.

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@kelnos kelnos requested a review from blast-hardcheese May 4, 2019

@blast-hardcheese
Copy link
Collaborator

left a comment

nice

@kelnos

This comment has been minimized.

Copy link
Member Author

commented May 4, 2019

right? i feel super dumb now.

@kelnos kelnos force-pushed the kelnos:fix-jackson-maps branch from af9dbb2 to 22c9d99 May 4, 2019

@kelnos kelnos merged commit 11d41ab into twilio:master May 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kelnos kelnos deleted the kelnos:fix-jackson-maps branch May 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.