Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#255 improvement - Fixed issue with type:file #283

Merged
merged 3 commits into from May 10, 2019

Conversation

Projects
None yet
2 participants
@tomasherman
Copy link
Contributor

commented May 5, 2019

Fixes issue with type: file and also adds test for mentioned failing case, but it seems to be working

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.
Tomas Herman

Tomas Herman added some commits May 5, 2019

Tomas Herman
Tomas Herman
@tomasherman

This comment has been minimized.

Copy link
Contributor Author

commented May 5, 2019

I'm not really sure how type: string format: binary should be handled...i patched it up to work for the person asking in #255 but i think we should open different issue on how to handle binary data properly

@blast-hardcheese

This comment has been minimized.

Copy link
Collaborator

commented May 10, 2019

Thanks again for the discussion!

@blast-hardcheese blast-hardcheese merged commit e413b91 into twilio:master May 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.