Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit type for parameter in AccumulatingUnmarshaller #285

Conversation

Projects
None yet
2 participants
@karolchmist
Copy link

commented May 6, 2019

If I try to generate server code for akka-http, I can't compile it. I get

[error] /home/karol/workspace/project/target/scala-2.11/src_managed/main/handlers/generated/AkkaHttpImplicits.scala:93:32: missing parameter type
[error]       accumulator.updateAndGet(x => acc(value) :: x)
[error]                                ^
[error] one error found
[error] (registry / Compile / compileIncremental) Compilation failed

I think the reason is my scala version (2.11.12).

This PR adds explicit type for x. Running example in sbt works fine after the change.

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@karolchmist karolchmist force-pushed the karolchmist:fix/accumulating-unmarchaller-parameter-type-scala-2.11 branch from af66070 to cea478b May 6, 2019

@karolchmist

This comment has been minimized.

Copy link
Author

commented May 6, 2019

I tried to reproduce the problem on Travis, but it seems to work fine...

I'd appreciate accepting this PR anyway, as it should solve my problem.

@blast-hardcheese
Copy link
Collaborator

left a comment

This is OK, though I try to stay away from stuff like this.

What version of scala are you running? If you're running 2.11 or lower, do you have -Xexperimental?

@blast-hardcheese blast-hardcheese force-pushed the twilio:master branch from 6a41c95 to 3f0f265 May 15, 2019

@karolchmist

This comment has been minimized.

Copy link
Author

commented May 21, 2019

2.11 without -Xexperimental, it may be the reason indeed.

In the end we don't need this feature, so I'll close this PR. Feel free to merge if needed. Thanks @blast-hardcheese !

@blast-hardcheese

This comment has been minimized.

Copy link
Collaborator

commented May 22, 2019

As 2.11 is almost completely EOL, unless there's significant interest in it, I think we'll keep this unmerged. Thank you for taking a look @karolchmist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.