Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic redaction via new vendor extension 'x-data-redaction' #316

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
2 participants
@kelnos
Copy link
Member

commented May 30, 2019

Redacts fields in circe- and jackson-generated objects' toString methods.

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@kelnos kelnos requested a review from blast-hardcheese May 30, 2019

@@ -141,6 +142,7 @@ object CirceProtocolGenerator {
case s: StringSchema => EmptyValueIsNull(s)
case _ => None
}).getOrElse(EmptyIsEmpty)
dataRedaction = DataRedaction(property).getOrElse(DataVisible)

This comment has been minimized.

Copy link
@blast-hardcheese

blast-hardcheese Jun 5, 2019

Collaborator

I think this feature will eventually need to be controllable via core interpreter, defining the default based on call site (possibly plugin configuration) such that for secure environments everything should be redacted by default

This comment has been minimized.

Copy link
@kelnos

kelnos Jun 5, 2019

Author Member

Yeah, that makes sense. Do you think we'd want to continue parse it out here, and then just give the core interp a chance to override it?

This comment has been minimized.

Copy link
@blast-hardcheese

blast-hardcheese Jun 5, 2019

Collaborator

Yeah -- I'm thinking a single Term that just Target.pure(DataVisible) defining the default. Eventually, it may consume the config parameters and use plugin configuration to differentiate, but I haven't thought that far ahead, mainly just interested in separating static defaults.

@kelnos kelnos merged commit da2f3cf into twilio:master Jun 5, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@kelnos kelnos deleted the kelnos:data-redaction-extension branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.