Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate identical parameters across different contentTypes #325

Merged
merged 2 commits into from Jun 14, 2019

Conversation

Projects
None yet
2 participants
@blast-hardcheese
Copy link
Collaborator

commented Jun 9, 2019

Resolves #324

When multiple content types are specified in consumes, deduplicate the parameters and mark ones that don't explicitly occur across all media types as not required.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@blast-hardcheese blast-hardcheese force-pushed the blast-hardcheese:resolve-324 branch 2 times, most recently from 6d94e2e to 66745e1 Jun 9, 2019

@blast-hardcheese blast-hardcheese requested a review from kelnos Jun 9, 2019

@blast-hardcheese

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 9, 2019

@kelnos I suspect that this will conflict with what you're doing in supporting distinct media types, but this is an attempt at squeezing slightly more mileage out of the content body shims.

@blast-hardcheese

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 10, 2019

Additionally, before moving this, I'll add a regression test that exercises this behaviour.

@kelnos

kelnos approved these changes Jun 10, 2019

@blast-hardcheese blast-hardcheese force-pushed the blast-hardcheese:resolve-324 branch from 66745e1 to 7fa9c18 Jun 13, 2019

blast-hardcheese added a commit to blast-hardcheese/guardrail that referenced this pull request Jun 13, 2019

@blast-hardcheese blast-hardcheese force-pushed the blast-hardcheese:resolve-324 branch from 7fa9c18 to bd9c061 Jun 13, 2019

@blast-hardcheese blast-hardcheese merged commit 35ce515 into twilio:master Jun 14, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@blast-hardcheese blast-hardcheese deleted the blast-hardcheese:resolve-324 branch Jun 14, 2019

@blast-hardcheese blast-hardcheese referenced this pull request Jun 16, 2019

Merged

Akka form data consumption #326

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.