Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akka form data consumption #326

Merged
merged 18 commits into from Jun 20, 2019

Conversation

Projects
None yet
2 participants
@blast-hardcheese
Copy link
Collaborator

commented Jun 9, 2019

Resolves #312

  • Switches to Unmarshallers for formData consumption to support both application/x-www-form-urlencoded and multipart/form-data, depending on what's in consumes
  • Relies heavily on parameter deduplication (#325)
  • If any consumes are application/x-www-form-urlencoded, all file parameters are forced to be optional.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@blast-hardcheese blast-hardcheese force-pushed the blast-hardcheese:akka-formData-consumption branch 3 times, most recently from 550fc4e to 2748c04 Jun 16, 2019

@blast-hardcheese blast-hardcheese referenced this pull request Jun 16, 2019

Merged

Upgrade http4s to version 0.20.0 #275

1 of 1 task complete

@blast-hardcheese blast-hardcheese force-pushed the blast-hardcheese:akka-formData-consumption branch from 9448204 to c4f3d44 Jun 19, 2019

@blast-hardcheese blast-hardcheese force-pushed the blast-hardcheese:akka-formData-consumption branch from c4f3d44 to 4a049b7 Jun 19, 2019

@kelnos

kelnos approved these changes Jun 19, 2019

Copy link
Member

left a comment

lgtm

@blast-hardcheese blast-hardcheese force-pushed the blast-hardcheese:akka-formData-consumption branch from 15e9e08 to 4b5f1d5 Jun 20, 2019

@blast-hardcheese blast-hardcheese force-pushed the blast-hardcheese:akka-formData-consumption branch from 4b5f1d5 to 09c88cd Jun 20, 2019

@kelnos kelnos merged commit 05b9d6d into twilio:master Jun 20, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@blast-hardcheese blast-hardcheese deleted the blast-hardcheese:akka-formData-consumption branch Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.