Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not import blaze client for http4s #335

Merged
merged 1 commit into from Jul 7, 2019

Conversation

Projects
None yet
2 participants
@hanny24
Copy link

commented Jul 4, 2019

There is no need to import org.http4s.client.blaze._ as it is client backend implementation specific namespace. I believe that generated code should be client backend agnostic.
Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.
@blast-hardcheese
Copy link
Collaborator

left a comment

Good call!

@blast-hardcheese blast-hardcheese merged commit 4937f61 into twilio:master Jul 7, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@hanny24 hanny24 deleted the hanny24:no-blaze-import branch Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.