Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not generate framework implicits when generating model only #337

Merged
merged 2 commits into from Jul 8, 2019

Conversation

Projects
None yet
2 participants
@hanny24
Copy link

commented Jul 8, 2019

When generating only model classes, current behavior is to generate also a file with implicits for given framework. This effectively means that generated code has a build dependency on http4s/akka-http/... even though it's not needed.

This PR changes that such that no file with framework specific implicits is generated when generating model classes only.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.
@blast-hardcheese
Copy link
Collaborator

left a comment

Good call

@blast-hardcheese

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

Fwiw, to keep the noise in the git history down, I'm going to rebase your changes -- if you wouldn't mind opening future PRs off master, that would be appreciated!

@blast-hardcheese blast-hardcheese merged commit 8740f7b into twilio:master Jul 8, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@hanny24 hanny24 deleted the hanny24:no-framework-for-models branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.