Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safety and exhaustivity refactors #358

Conversation

@blast-hardcheese
Copy link
Collaborator

commented Jul 31, 2019

This PR largely applies to akka-http, though the intent is as more functionality gets fleshed out, more of the requirements will move to core and trickle out into the rest of the frameworks/languages.

  • Starting with changing consumes to NonEmptyList (flipped for the akka-http client generator)
  • Two new exceptions in cases where we don't have either Free or Target (these will continue to flag as warnings as time goes on, and will be resolved as we go back to reduce the number of warnings in the build, moving towards -Wall)
  • Removing some NPEs in the 2to3 shim (we were doing stuff like Option(getSchema.getType))

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@blast-hardcheese blast-hardcheese requested a review from kelnos Jul 31, 2019

@blast-hardcheese blast-hardcheese referenced this pull request Aug 1, 2019
1 of 1 task complete

@blast-hardcheese blast-hardcheese force-pushed the blast-hardcheese:safety-and-exhaustivity-refactors branch from ae99809 to cb4ceb8 Aug 1, 2019

@blast-hardcheese blast-hardcheese merged commit 4c05998 into twilio:master Aug 1, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@blast-hardcheese blast-hardcheese deleted the blast-hardcheese:safety-and-exhaustivity-refactors branch Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.