Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #179 #362

Merged
merged 2 commits into from Sep 2, 2019

Conversation

@hanny24
Copy link
Contributor

commented Aug 5, 2019

This PR fixes #179

In summary, we don't use Http4sDsl for response construction, but we build Response manually instead.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@hanny24 hanny24 force-pushed the hanny24:issue-179 branch from 92c1914 to c551657 Aug 12, 2019

@hanny24

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

@blast-hardcheese Can you please take look at it?

Also I was thinking that it might be a good idea to setup some sort of gitter channel. What do you think?

@kelnos

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

@hanny24 so as not to leave you hanging: @blast-hardcheese is out on vacation this week and next; I'm sure he'll be able to look at it when he gets back (I'm not familiar enough with http4s to review this).

@blast-hardcheese
Copy link
Collaborator

left a comment

I'm onboard with this. Again, to reiterate what @kelnos said, please pardon the delay in review, I was in the mountains with not even cell service 😄

@blast-hardcheese blast-hardcheese merged commit 7e0ba22 into twilio:master Sep 2, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.