Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generated io.circe.java8 imports and add documentation #363

Open
wants to merge 3 commits into
base: master
from

Conversation

@hugo-vrijswijk
Copy link

commented Aug 5, 2019

Fixes #361

I've removed the imports and added some documentation. There could be more places where documentation needs to be updated.

TODO: Bigger local test with this version. I'll do that tonight (EU time).

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@hugo-vrijswijk hugo-vrijswijk force-pushed the hugo-vrijswijk:remove-java8-imports branch 5 times, most recently from 475ee8f to e4ef3ef Aug 6, 2019

@hugo-vrijswijk hugo-vrijswijk force-pushed the hugo-vrijswijk:remove-java8-imports branch from e4ef3ef to e938c31 Aug 7, 2019

@hugo-vrijswijk

This comment has been minimized.

Copy link
Author

commented Aug 7, 2019

The build seems to be failing with the following error:

[error] /home/travis/build/twilio/guardrail/modules/sample-endpoints/target/generated/additionalProperties/client/endpoints/definitions/package.scala:11:57: could not find implicit value for parameter instance: io.circe.Decoder[java.time.Instant]

From what I can tell, the sample-endpoints project is a ScalaJS project (it has .enablePlugins(ScalaJSPlugin), so it makes sense to me that it cannot find java.time.Instant decoders. Unless I am missing something. I am not sure what the way forward here is.

@@ -153,7 +153,7 @@ class Issue148Suite extends FunSuite with Matchers with EitherValues with ScalaF
.toEntity
) ~> route ~> check {
rejection match {
case MalformedFormFieldRejection("foo", message, _) => message shouldBe "expected json value got b (line 1, column 1)"
case MalformedFormFieldRejection("foo", message, _) => message shouldBe "expected json value got 'blep' (line 1, column 1)"

This comment has been minimized.

Copy link
@blast-hardcheese

blast-hardcheese Aug 10, 2019

Collaborator

This is somewhat worrisome; Do you have an context on why this changed?

This comment has been minimized.

Copy link
@hugo-vrijswijk

hugo-vrijswijk Aug 10, 2019

Author

I think it's the change in Circe version

@hugo-vrijswijk hugo-vrijswijk changed the title WIP: Remove generated io.circe.java8 imports and add documentation Remove generated io.circe.java8 imports and add documentation Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.